Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add State Property to Schedule EventSource in StateMachine #2468

Merged
merged 1 commit into from
Aug 18, 2022
Merged

feat: Add State Property to Schedule EventSource in StateMachine #2468

merged 1 commit into from
Aug 18, 2022

Conversation

konoui
Copy link
Contributor

@konoui konoui commented Aug 10, 2022 •
edited
Loading

Issue #, if available:
#2467

Description of changes:

add State property to Schedule EventSource for AWS::Serverless::StateMachine.

Description of how you validated changes:

added invalid input and transform tests

Checklist:

  • Add/update unit tests using:
  • Add/update integration tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Aug 10, 2022
@jfuss jfuss self-requested a review August 10, 2022 14:34
@jfuss jfuss self-assigned this Aug 10, 2022
jfuss
jfuss approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this to SAM @konoui

@jfuss jfuss added area/step-function and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Aug 16, 2022
@hawflau hawflau merged commit c2df06a into aws:develop Aug 18, 2022
@chrisoverzero chrisoverzero mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfuss jfuss jfuss approved these changes

@hawflau hawflau hawflau approved these changes

Assignees

@jfuss jfuss

Labels
area/step-function maintainer/need-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@konoui @hawflau @jfuss @aws-sam-cli-bot