chore: Add basic mypy check (no behavior change) #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahung
commented
Sep 1, 2022
| @@ -1,3 +0,0 @@ | |||
| # flake8: noqa | |||
|
|
|||
| from samtranslator.translator import add_default_parameter_values | |||
There was a problem hiding this comment.
Explanation: this file is not used, and samtranslator.translator doesn't have add_default_parameter_values
| @@ -179,9 +181,7 @@ def _parse(self, globals_dict): | |||
|
|
|||
| globals = {} | |||
| if not isinstance(globals_dict, dict): | |||
| raise InvalidGlobalsSectionException( | |||
| self._KEYWORD, "It must be a non-empty dictionary".format(self._KEYWORD) | |||
There was a problem hiding this comment.
Explanation: .format() is noop because there are not %s in the string template.
| @@ -607,7 +607,7 @@ def _validate_dlq(self): | |||
| if not self.DeadLetterQueue.get("Type") or not self.DeadLetterQueue.get("TargetArn"): | |||
| raise InvalidResourceException( | |||
| self.logical_id, | |||
| "'DeadLetterQueue' requires Type and TargetArn properties to be specified.".format(valid_dlq_types), | |||
There was a problem hiding this comment.
Explanation: .format() is noop because there are not %s in the string template.
| @@ -20,11 +20,11 @@ | |||
|
|
|||
| _CORS_WILDCARD = "*" | |||
| CorsProperties = namedtuple( | |||
| "_CorsProperties", ["AllowMethods", "AllowHeaders", "AllowOrigins", "MaxAge", "ExposeHeaders", "AllowCredentials"] | |||
There was a problem hiding this comment.
Explanation: first parameter needs to be consistent with assigned type name. the literal _CorsProperties is only a type hint name, not used anywhere in our codebase.
aahung
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Have bare minimal type check and we can enable more checks in the future to ensure code quality and correctness.
Description of how you validated changes:
No behavior changes have been made in this PR.
Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.