Add FirehoseWritePolicy and FirehoseCrudPolicy #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additionally, I have no idea how to test this behavior locally. |
|
Agreed we need integration tests that should be open sourced as well. Will try to get those out soon. In the meantime, it could be useful to transform your SAM templates with these policies as CFN templates and call "aws cloudformation deploy" to create the stack and test. Will get these reviewed by our security engineers in the meantime. |
salmanap
approved these changes
May 23, 2018
brettstack
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: no issue
Description of changes: I've created two new policy templates in support of Kinesis Firehose use. For my own use case, I just need the FirehoseWritePolicy, which I am currently constructing manually in my SAM template. As this is my first real contribution to the repo, I am open to any changes you think are appropriate to make it fit.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.