fix: log a warning on invalid schema validation #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylynn
approved these changes
Jun 11, 2018
ombozek
approved these changes
Jun 11, 2018
brettstack
added a commit
that referenced
this pull request
Jun 11, 2018
* doc: update DESIGN.md to include an Overview and entry point for SAM (#370) * Update DESIGN.md to include an Overview and entry point for SAM * Updated wording in DESIGN.md based on PR feedback * docs(example): improve microservice-http-endpoint-python3 example (#415) * Remove unnecessary index.js" * Moved common config to template Globals and uncomment debug log. * Add sample payload and commands for testing. * Rename test script as a script. * Exit from script after command. * Simplify use case for easier startup. - Move table creation into template. - Eliminates need to provide table name in every REST call. - Fix GET with no params. - Split test.sh script from output log. * Address requested changes. * doc(example): update api_backend example to use ES6 arrow function immediate return (#446) Since this code is using ES6 we can use the short version of returning a param * feat(event-source): add SQS as Lambda event source (#451) * feat(cli): add lightweight transformer cli (#459) * bug: fix ANY method ARN generation using wildcard (#449) * fix(event-source): fix SQS Queue schema to allow intrinsic functions (#465) * fix: log a warning on invalid schema validation (#466)
brettstack
added a commit
that referenced
this pull request
Jun 12, 2018
* doc: update DESIGN.md to include an Overview and entry point for SAM (#370) * Update DESIGN.md to include an Overview and entry point for SAM * Updated wording in DESIGN.md based on PR feedback * docs(example): improve microservice-http-endpoint-python3 example (#415) * Remove unnecessary index.js" * Moved common config to template Globals and uncomment debug log. * Add sample payload and commands for testing. * Rename test script as a script. * Exit from script after command. * Simplify use case for easier startup. - Move table creation into template. - Eliminates need to provide table name in every REST call. - Fix GET with no params. - Split test.sh script from output log. * Address requested changes. * doc(example): update api_backend example to use ES6 arrow function immediate return (#446) Since this code is using ES6 we can use the short version of returning a param * feat(event-source): add SQS as Lambda event source (#451) * feat(cli): add lightweight transformer cli (#459) * bug: fix ANY method ARN generation using wildcard (#449) * fix(event-source): fix SQS Queue schema to allow intrinsic functions (#465) * fix: log a warning on invalid schema validation (#466)
jfuss
reviewed
Jun 13, 2018
| @@ -2,6 +2,7 @@ | |||
| from samtranslator.validator.validator import SamTemplateValidator | |||
| from samtranslator.model import ResourceTypeResolver, sam_resources | |||
| from samtranslator.plugins import LifeCycleEvents | |||
| import logging | |||
There was a problem hiding this comment.
This uses the root logger, which will log in any one using SAM to translate without a way to turn it off.
logging should be done by adding a __name__.
logger = logging.getLogger(__name__) and then log by doing logger.warning("Logging a Warning")
There was a problem hiding this comment.
Can you send a PR? How do other consumers then turn that off?
There was a problem hiding this comment.
https://stackoverflow.com/a/35325280
Should magically work. You can also manipulate the libraries logger too. For example, SAM CLI could then turn the SAM Translators logging on for a given level if they so wanted to.
There was a problem hiding this comment.
Based on https://stackoverflow.com/questions/24750523/disable-output-of-root-logger we're handling it like this now:
https://github.com/awslabs/cfn-python-lint/pull/117/files#diff-6d7631d1ad3e87ab0c24664abb771bc4R79 (Work In Progress)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Log a warning on invalid schema validation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.