refactor: add support for Python 3 (#490) #491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add support for Python 3 (feat: add support for Python 3 #428)
refactor: Updated imports to by Py3 compliant
refactor: Move class variable creation to constructor in globals.py
Without moving this to the init, the globals.py file will not run
in Py3 because it can't reference the constants.
In Py3, the function .iteritems() on a dict was removed and replaced
with .items().
In Py3, .itervalues() and .iteritems() was replaced with .values() and
.items(), respectfully.
In Py3, the .keys() method on a dictionary returns a dict_keys object
that is a view into the dictionary. In Py2, it returns a list. To
support Py3, we need to convert the .keys() to a list.
In Py3, the .keys() method on a dictionary returns a dict_keys object
that is a view into the dictionary. In Py2, it returns a list. To
support Py3, we need to convert the .keys() to a list.
Updated .iteritems() to items()
refactor: More updating to be Py3 compliant
refactor: Make hashing constisent between py2 and py3
refactor: Make exceptions sortable to allow error case tests to pass in Py3
fix: add support for Python 3 (fix: Fixing unit tests to work in Python 3 #445)
refactor: Updated imports to by Py3 compliant
refactor: Move class variable creation to constructor in globals.py
Without moving this to the init, the globals.py file will not run
in Py3 because it can't reference the constants.
In Py3, the function .iteritems() on a dict was removed and replaced
with .items().
In Py3, .itervalues() and .iteritems() was replaced with .values() and
.items(), respectfully.
In Py3, the .keys() method on a dictionary returns a dict_keys object
that is a view into the dictionary. In Py2, it returns a list. To
support Py3, we need to convert the .keys() to a list.
In Py3, the .keys() method on a dictionary returns a dict_keys object
that is a view into the dictionary. In Py2, it returns a list. To
support Py3, we need to convert the .keys() to a list.
Updated .iteritems() to items()
refactor: More updating to be Py3 compliant
refactor: Make hashing constisent between py2 and py3
refactor: Make exceptions sortable to allow error case tests to pass in Py3
feat: Run tox from Travis-CI
feat: Update tox to run in Py2 and Py3
refactor: Force sorting behavior to be Py2 compatible and update Deployment logicalid hash
fix: Update tox to run tests against Py27 and Py36
Update Travis config to run Py2 and Py3 tests in parallel
Setting region env var in tox file for Travis to pick up
Set AWS region in travis file
Pass AWS_* env vars to tox
Fixing ordering of resource types in Globals error message
Py2/3 compatible implementation of string encoding for logicalId generator
Also added lots of comments explaining why/how the deep sorting of lists
work in unit tests
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.