fix: add missing parameter to s3 bucket resource #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not an ideal situation- needing to update this resource with every single new feature. We should consider a way to update our underlying design so we don't need to continually update these resources, but let them pass through parameters to CFN.
jlhood
suggested changes
Dec 4, 2018
jlhood
approved these changes
Dec 5, 2018
paoptu023
approved these changes
Dec 5, 2018
|
Any idea when this will be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not an ideal situation- needing to update this resource with every single new feature. We should consider a way to update our underlying design so we don't need to continually update these resources, but let them pass through parameters to CFN.
Issue #, if available:
#679
Description of changes:
Add missing
PublicAccessBlockConfigurationparameter to S3 bucketsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.