Add example on how to use S3 events for lambda functions written in Go using sam #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/v1.10.0 #737 +/- ##
================================================
Coverage 94.18% 94.18%
================================================
Files 67 67
Lines 2685 2685
Branches 478 478
================================================
Hits 2529 2529
Misses 80 80
Partials 76 76Continue to review full report at Codecov.
|
keetonian
suggested changes
Jan 1, 2019
There was a problem hiding this comment.
Thanks for this contribution, it looks good! Thank you for modifying the README and giving instructions on how to build and use this example, I will follow these steps and report if there are any issues. Just need to make that one template fix and this should be good to go.
|
@keetonian thanks for reviewing my pull request and the advise. |
keetonian
previously approved these changes
Jan 3, 2019
paoptu023
previously approved these changes
Jan 3, 2019
keetonian
approved these changes
Jan 3, 2019
paoptu023
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: This PR shows how to use aws sam to develop application that will trigger lambda function written in Go on S3 events like image upload.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.