Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #814

Merged
merged 3 commits into from
Feb 19, 2019
Merged

Develop #814

merged 3 commits into from
Feb 19, 2019

Conversation

nicklit
Copy link
Contributor

@nicklit nicklit commented Feb 14, 2019

Issue #, if available:

Description of changes:
Add pseudo params for partitions in some spots

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #814 into develop will decrease coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #814      +/-   ##
===========================================
- Coverage    94.85%   94.23%   -0.62%     
===========================================
  Files           67       67              
  Lines         2952     2688     -264     
  Branches       576      478      -98     
===========================================
- Hits          2800     2533     -267     
- Misses          76       80       +4     
+ Partials        76       75       -1
Impacted Files Coverage Δ
samtranslator/model/eventsources/push.py 86.06% <0%> (-4.24%) ⬇️
samtranslator/model/api/api_generator.py 96.13% <0%> (-1.92%) ⬇️
samtranslator/model/sam_resources.py 95.74% <0%> (-1.24%) ⬇️
samtranslator/model/eventsources/cloudwatchlogs.py 100% <0%> (ø) ⬆️
samtranslator/model/eventsources/pull.py 91.66% <0%> (+0.14%) ⬆️
samtranslator/model/__init__.py 96.85% <0%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651550c...19871d1. Read the comment docs.

@brettstack
Copy link
Contributor

Thanks for this!

@keetonian keetonian merged commit 4bddf27 into aws:develop Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants