Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid event type error #918

Merged
merged 1 commit into from
May 17, 2019
Merged

fix: invalid event type error #918

merged 1 commit into from
May 17, 2019

Conversation

praneetap
Copy link
Contributor

@praneetap praneetap commented May 14, 2019

Issue #, if available:
#915
Description of changes:
handle Attribute error in sam_resources to return a 4xx error for invalid event type in function
Description of how you validated changes:
Added tests for bad event type and ran make pr.
Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #918 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #918   +/-   ##
========================================
  Coverage    94.66%   94.66%           
========================================
  Files           69       69           
  Lines         3016     3016           
  Branches       561      561           
========================================
  Hits          2855     2855           
  Misses          85       85           
  Partials        76       76
Impacted Files Coverage Δ
samtranslator/model/sam_resources.py 95.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ab9b8...7420b95. Read the comment docs.

@keetonian keetonian merged commit 1a7a4e6 into aws:develop May 17, 2019
@praneetap praneetap deleted the event branch May 17, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants