Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused CollectionId parameter of RekognitionFacesPolicy #985

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

53ningen
Copy link
Contributor

@53ningen 53ningen commented Jun 19, 2019

Issue:
Fixes #974

Description of changes:
Removed unused CollectionId parameter of RekognitionFacesPolicy (policy template)

Description of how you validated changes:

  • make test: passed all tests
  • verified transformed template in the steps written in DEVELOPMENT_GUIDE

using this SAM template

# template.yaml
Resources:
  HogeFugaFunction:
    Type: AWS::Serverless::Function
    Properties:
      CodeUri: src/hogefuga/
      Handler: app.lambda_handler
      Policies:
        - RekognitionFacesPolicy: {}

I executed the commands below:

aws cloudformation package --template-file MY_TEMPLATE_PATH/template.yaml --output-template-file output-template.yaml --s3-bucket MY_S3_BUCKET
bin/sam-translate.py --template-file=output-template.yaml

Then I got expected transformed template like this

...
          {
            "PolicyName": "HogeFugaFunctionRolePolicy1", 
            "PolicyDocument": {
              "Statement": [
                {
                  "Action": [
                    "rekognition:CompareFaces", 
                    "rekognition:DetectFaces"
                  ], 
                  "Resource": "*", 
                  "Effect": "Allow"
                }
              ]
            }
          }
...

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation:
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #985 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #985   +/-   ##
========================================
  Coverage    94.71%   94.71%           
========================================
  Files           69       69           
  Lines         3160     3160           
  Branches       606      606           
========================================
  Hits          2993     2993           
  Misses          85       85           
  Partials        82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88df20c...6c4c429. Read the comment docs.

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@praneetap praneetap merged commit 6004308 into aws:develop Jul 2, 2019
@53ningen 53ningen deleted the bugfix/template_policy branch July 2, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants