-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: openapi postprocess bug in request models with security definitions #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging from awslabs/develop
For example, in https://travis-ci.org/awslabs/serverless-application-model/jobs/538917819: /home/travis/build/awslabs/serverless-application-model/.tox/py36/lib/python3.6/site-packages/jsonschema/validators.py:893: DeprecationWarning: The metaschema specified by $schema was not found. Using the latest draft to validate, but this will raise an error in the future. cls = validator_for(schema)
chore: merge develop
Codecov Report
@@ Coverage Diff @@
## release/v1.13.0 #990 +/- ##
===================================================
+ Coverage 94.71% 94.86% +0.14%
===================================================
Files 69 69
Lines 3160 3152 -8
Branches 606 602 -4
===================================================
- Hits 2993 2990 -3
+ Misses 85 84 -1
+ Partials 82 78 -4
Continue to review full report at Codecov.
|
keetonian
approved these changes
Jun 24, 2019
brettstack
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
securityDefinitions
don't get changed tocomponents/securitySchemes
if request models are defined, and this breaks the cloudformation deployment.Description of changes:
Moved openapi postprocess to a single function.
Description of how you validated changes:
Wrote unit tests
Deployed the following template successfully on cfn
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.