Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for native web workloads #739

Merged
merged 15 commits into from
Jan 30, 2024
Merged

Add support for native web workloads #739

merged 15 commits into from
Jan 30, 2024

Conversation

olegz
Copy link
Collaborator

@olegz olegz commented Jan 12, 2024 •
edited by deki
Loading

  • Simplify existing web support for non-native environments
  • Make native and non-native consistently relying on same libraries from spring-cloud-function and AWS

Issue #, if available: #335

Description of changes:

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

olegz and others added 2 commits January 12, 2024 14:20
@olegz
Add support for native web workloads
566e926 
- Simplify existing web support for non-native environments
- Make native and non-native consistently relying on same libraries from spring-cloud-function and AWS
@deki
chore: exclude native implementation from coverage report due to comp…
fa819bc 
…lexity of the test setup
deki
deki requested changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@deki deki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this important contribution, Oleg. Overall it's working for me. Added some suggestions for improvements but as I'm not good at naming things as well, I will also ask some other colleagues to review :-)

...-container-springboot3/src/main/java/com/amazonaws/serverless/proxy/spring/AWSHttpUtils.java Outdated Show resolved Hide resolved
samples/springboot3/alt-pet-store/template.yml Outdated Show resolved Hide resolved
...-container-springboot3/src/main/java/com/amazonaws/serverless/proxy/spring/AWSHttpUtils.java Outdated Show resolved Hide resolved
...-container-springboot3/src/main/java/com/amazonaws/serverless/proxy/spring/AWSHttpUtils.java Outdated Show resolved Hide resolved
...-container-springboot3/src/main/java/com/amazonaws/serverless/proxy/spring/AWSHttpUtils.java Outdated Show resolved Hide resolved
...ainer-springboot3/src/main/java/com/amazonaws/serverless/proxy/spring/AWSTypesProcessor.java Outdated Show resolved Hide resolved
...-springboot3/src/main/java/com/amazonaws/serverless/proxy/spring/AWSWebRuntimeEventLoop.java Outdated Show resolved Hide resolved
...-container-springboot3/src/main/java/com/amazonaws/serverless/proxy/spring/AWSHttpUtils.java Outdated Show resolved Hide resolved
samples/springboot3/alt-pet-store/pom.xml Show resolved Hide resolved
@deki deki mentioned this pull request Jan 16, 2024
Closed
@deki deki added this to the Release 2.0 milestone Jan 24, 2024
@olegz olegz mentioned this pull request Jan 24, 2024
Closed
2 tasks
olegz and others added 9 commits January 24, 2024 21:48
@deki deki merged commit 7ca2f07 into aws:main Jan 30, 2024
4 checks passed
@deki deki mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deki deki deki requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@olegz @deki