Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: SyntheticClone's getArchetype should return Optional<ShapeId> #262

Closed
jasdel opened this issue Jan 15, 2021 · 0 comments · Fixed by #261
Closed

codegen: SyntheticClone's getArchetype should return Optional<ShapeId> #262

jasdel opened this issue Jan 15, 2021 · 0 comments · Fixed by #261

Comments

@jasdel
Copy link
Contributor

jasdel commented Jan 15, 2021

The SynthenticClone's getArchetype method should return an Optional<ShapeId>. To more correctly show this is an optional member.

Originally posted by @skmcgrail in #261 (comment)

jasdel added a commit to jasdel/smithy-go that referenced this issue Jan 15, 2021
jasdel added a commit that referenced this issue Jan 16, 2021
Updates the SDK's generated serializers and deserializers to skip unmodeled
input and output shapes for operations.

This issue caused generated deserializers to attempt to deserialize
operation responses that were not modeled, resulting in an error.
Whereas the SDK should of ignored the response if one was present for
operations without a modeled output.

Related to aws/aws-sdk-go-v2#1047
Fixes #262

#### Input
Unmodeled Input shape serializer functions are not generated.

This update changes API protocol operation serializers for HTTP binding protocols to skip serialization of the request document if the operation's input was not modeled.

This change is **not** applied to HTTP RPC protocol serializations. This is due to the AwsQuery protocol requiring some protocol specific elements to always be serialized regardless if an input is modeled or not.

#### Output
Unmodeled output shape serializer functions are not generated.

This update changes all API protocol operation deserializers to discard the response body if the operation's output was not modeled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant