Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement HttpRequestBodyStream for files #308

Open
aajtodd opened this issue Apr 13, 2021 · 1 comment
Open

implement HttpRequestBodyStream for files #308

aajtodd opened this issue Apr 13, 2021 · 1 comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@aajtodd
Copy link
Contributor

aajtodd commented Apr 13, 2021

We should probably consider wrapping java.io.File into something that implements HttpRequestBodyStream (or better yet special casing it to just use the existing aws_input_stream implementation: https://github.com/awslabs/aws-c-io/blob/main/include/aws/io/stream.h#L94 and avoid going through JNI all together (for reading the file))

@yasminetalby yasminetalby added feature-request A feature should be added or improved. p3 This is a minor priority issue labels Jun 26, 2023
@jmklix
Copy link
Member

jmklix commented May 6, 2024

This isn't needed anymore: awslabs/aws-sdk-kotlin#227 (comment)

We've significantly refactored the I/O model as well as implemented signing directly in Kotlin since this issue was opened. Closing as there is no signs this is actually any kind of bottleneck, we can always re-evaluate with concrete use cases/issues if that isn't the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

3 participants