Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make 'configPath' optional #343

Merged
merged 4 commits into from
Jun 9, 2023
Merged

fix: make 'configPath' optional #343

merged 4 commits into from
Jun 9, 2023

Conversation

malachi-constant
Copy link
Contributor

Fixes #342

@malachi-constant malachi-constant added the bug Something isn't working label Jun 8, 2023
@malachi-constant malachi-constant self-assigned this Jun 8, 2023
@malachi-constant malachi-constant linked an issue Jun 8, 2023 that may be closed by this pull request
config: get_env_config() should have config_path as optional #342
Closed
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: cc297d5
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

chore: self mutation
090c4c0 
Signed-off-by: github-actions <github-actions@github.com>
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 090c4c0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 9a73ac3
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

chore: self mutation
5c72d33 
Signed-off-by: github-actions <github-actions@github.com>
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
  • Commit ID: 5c72d33
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant merged commit 689c795 into main Jun 9, 2023
5 checks passed
@malachi-constant malachi-constant deleted the 342-config-get_env_config-should-have-config_path-as-optional branch June 9, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@anmolsgandhi anmolsgandhi Awaiting requested review from anmolsgandhi

Assignees

@malachi-constant malachi-constant

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config: get_env_config() should have config_path as optional
2 participants
@malachi-constant @LeonLuttenberger