Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExternalId for all assume role calls #66

Closed
bundyfx opened this issue Jun 13, 2019 · 2 comments
Closed

Use ExternalId for all assume role calls #66

bundyfx opened this issue Jun 13, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@bundyfx
Copy link
Contributor

bundyfx commented Jun 13, 2019

When ADF assumes any role, it should use a dynamically generated externalId that is automatically rotated to ensure ADF roles can never be assumed by anything other than ADF itself.

@bundyfx bundyfx added the enhancement New feature or request label Jun 13, 2019
@bundyfx bundyfx added this to the 1.1.0 milestone Jun 13, 2019
@bundyfx
Copy link
Contributor Author

bundyfx commented Jun 14, 2019

On top of this, the Role that is used by ADF to perform the initial base stack creation or update should have only the minimal required permissions available to it to create the base stack. If a user wants to add more resource into the base stack then the permissions should be extended to allow this. Otherwise we should default to least privilege access of the cross account access role.

@bundyfx bundyfx removed this from the 1.1.0 milestone Jun 30, 2019
@bundyfx
Copy link
Contributor Author

bundyfx commented Jul 13, 2019

For now, we're not going to add externalId for assume role calls, it doesnt add anything major in terms for security in this sense. Ideally we would have a way to lockdown the ADF cross account role IAM policy after it has setup the base stack. This could be a flag added to the adfconfig.yml to help secure everything down, but for now this is not mandatory.

@bundyfx bundyfx closed this as completed Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant