Skip to content

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Apr 11, 2022

Issue number:

Summary

Fixes the drops dow the issue templates

Changes

Please provide a summary of what's being changed

Update dropdown format to be matching the GitHub docs:

User experience

Please share what the user experience looks like before and after this change

Drop downs now match what the user should be capturing.

Screen Shot 2022-04-10 at 5 09 10 PM

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 11, 2022
@boring-cyborg boring-cyborg bot added the internal Maintenance changes label Apr 11, 2022
@github-actions github-actions bot added the bug Something isn't working label Apr 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #1106 (c5c7f40) into develop (f24332d) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1106   +/-   ##
========================================
  Coverage    99.96%   99.96%           
========================================
  Files          119      119           
  Lines         5377     5378    +1     
  Branches       613      613           
========================================
+ Hits          5375     5376    +1     
  Partials         2        2           
Impacted Files Coverage Δ
...ws_lambda_powertools/middleware_factory/factory.py 100.00% <0.00%> (ø)
...ws_lambda_powertools/utilities/idempotency/base.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f24332d...c5c7f40. Read the comment docs.

@michaelbrewer
Copy link
Contributor Author

@heitorlessa for review and testing i cloned the templates here:

@sthulb
Copy link
Contributor

sthulb commented Apr 12, 2022

Hi @michaelbrewer - as per the contribution guidelines, please wait until the issue has been triaged before creating a pull redirect.

@sthulb sthulb closed this Apr 12, 2022
@michaelbrewer
Copy link
Contributor Author

@sthulb sure. Just wanted to demonstrate the fix. Looking forward to the issue being resolved.

@sthulb
Copy link
Contributor

sthulb commented Apr 12, 2022

As per #1105, this has been resolved elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants