Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

programmatically_include_default_files test fails on Windows due to Unix-style file paths #1117

Open
Velfi opened this issue Mar 27, 2024 · 1 comment
Open

programmatically_include_default_files test fails on Windows due to Unix-style file paths #1117

Velfi opened this issue Mar 27, 2024 · 1 comment
Labels
bug This issue is a bug. p2 This is a standard priority issue

Comments

@Velfi
Copy link
Contributor

Velfi commented Mar 27, 2024

Describe the bug

The programmatically_include_default_files test fails on Windows due to Unix-style file paths.

It's located in aws-config but is being moved to the aws-runtime crate soon.

Expected Behavior

test passes

Current Behavior

test fails

Reproduction Steps

on Windows,

  • cd into the aws-config crate
  • run cargo test --all-features programmatically_include_default_files
  • The test will fail

(If it doesn't run the test, remove any #[ignore] and try again.)

Possible Solution

No response

Additional Information/Context

No response

Version

HEAD

Environment details (OS name and version, etc.)

Windows 11

Logs

No response
@Velfi Velfi added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 27, 2024
@Velfi
Copy link
Contributor Author

Velfi commented Mar 27, 2024 •
edited
Loading

I don't understand how this ever passed in the first place. Are we not running aws-config tests on Windows?

@Velfi Velfi removed the needs-triage This issue or PR still needs to be triaged. label Mar 27, 2024
@jmklix jmklix added pending-release This issue will be fixed by an approved PR that hasn't been released yet. p2 This is a standard priority issue labels Mar 29, 2024
@jmklix jmklix removed the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Velfi @jmklix