Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Spark 2.3 #54

Closed
hangelwen opened this issue Sep 30, 2018 · 4 comments
Closed

Support Spark 2.3 #54

hangelwen opened this issue Sep 30, 2018 · 4 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed high-priority required-for-release

Comments

@hangelwen
Copy link

Hi Deequ team,

This is a pretty useful tool. However, it only supports Spark 2.2. Is there a plan to support Spark 2.3 version?

@sscdotopen
Copy link
Contributor

Hi,

We haven't done extensive testing, but deequ should also work with Spark 2.3, as Spark is guaranteeing stability of its non-experimental APIs for all 2.X releases..

@hangelwen
Copy link
Author

@sscdotopen thanks for the quick reply.

I tried and it does not work on Spark 2.3. One issue I found it that some variables defined for HyperloglogPlus was moved from HyperLogLogPlusPlus to HyperLogLogPlusPlusHelper in this PR

https://github.com/awslabs/deequ/blob/master/src/main/scala/com/amazon/deequ/analyzers/catalyst/StatefulHyperloglogPlus.scala#L195
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/HyperLogLogPlusPlusHelper.scala#L280

@sscdotopen sscdotopen changed the title Support other Spark versions Support Spark 2.3 Sep 30, 2018
@sscdotopen sscdotopen added the bug Something isn't working label Sep 30, 2018
@sscdotopen
Copy link
Contributor

Thank you for the hint, I did not think about the fact that we also extended some internal functions. I'll file this issue as a bug on our side, and we will have a look into that.

@sscdotopen sscdotopen self-assigned this Oct 1, 2018
This was referenced Oct 1, 2018
@sscdotopen
Copy link
Contributor

@hangelwen We think we have fixed the incompatibility, we will release a new RC later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed high-priority required-for-release
Projects
None yet
Development

No branches or pull requests

2 participants