Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jackson depedency #39

Open
embano1 opened this issue Jun 7, 2023 · 3 comments
Open

Remove jackson depedency #39

embano1 opened this issue Jun 7, 2023 · 3 comments

Comments

@embano1
Copy link
Contributor

embano1 commented Jun 7, 2023

Discussed with @agebhar1 yesterday that there might be optimization we can do in the JSON (de)serialization path and jackson might be overkill for our task. Tracking this as an issue to revisit the JSON conversion logic in the EventBridgeWriter implementation.
@agebhar1 agebhar1 mentioned this issue Jun 11, 2023
Merged
2 tasks
@maschnetwork
Copy link
Contributor

Maybe light weight alternative jackson-jr would do it.

@agebhar1
Copy link
Contributor

Here is a nice benchmark of different libraries. It's interesting that the simple org.json is pretty slow.

@embano1
Copy link
Contributor Author

embano1 commented Jun 12, 2023

jackson-jr doesn't look to bad 👍🏻

@embano1 embano1 added this to the 1.2.0 milestone Aug 28, 2023
@kristianhellum kristianhellum mentioned this issue Sep 4, 2023
Closed
@embano1 embano1 modified the milestones: 1.2.0, 1.3.0 Jan 15, 2024
@embano1 embano1 removed this from the 1.3.0 milestone May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agebhar1 @embano1 @maschnetwork