Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix: only allow scopes to be returned iff it matches resourceType #88

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

rsmayda
Copy link
Contributor

@rsmayda rsmayda commented Sep 8, 2022

Issue #, if available: #83

Description of changes: Checks to ensure that there is at least 1 valid scope against the resourceType for search-type requests. If there isn't the jwt validation will fail

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rsmayda rsmayda added the bug Something isn't working label Sep 8, 2022
@rsmayda rsmayda self-assigned this Sep 8, 2022
@rsmayda rsmayda requested a review from a team as a code owner September 8, 2022 19:52
@github-actions github-actions bot added the size/s label Sep 8, 2022
Copy link
Contributor

@ssvegaraju ssvegaraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! Just to confirm I understood correctly:
If a search performed with (rev)/include (e.g. we request a DocumentReference and do an _include to get the Patient resource, then as long as we have the scope for the DocumentReference, the patient scopes won't be filtered out, correct?

@rsmayda
Copy link
Contributor Author

rsmayda commented Sep 8, 2022

I think this looks good! Just to confirm I understood correctly: If a search performed with (rev)/include (e.g. we request a DocumentReference and do an _include to get the Patient resource, then as long as we have the scope for the DocumentReference, the patient scopes won't be filtered out, correct?

That's right!

@rsmayda rsmayda merged commit 18b059e into mainline Sep 8, 2022
@rsmayda rsmayda deleted the system branch September 8, 2022 20:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants