Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

feat: Rest hook Lambda #558

Merged
merged 5 commits into from
Feb 11, 2022
Merged

feat: Rest hook Lambda #558

merged 5 commits into from
Feb 11, 2022

Conversation

Bingjiling
Copy link
Contributor

@Bingjiling Bingjiling commented Feb 9, 2022

Issue #, if available:

Description of changes:

  • Create Lambda that sends rest-hook POST and PUT notifications
  • Tested with event {"subscriptionId": "123456","channelType":"rest-hook","endpoint": "https://postman-echo.com/post","channelHeader": ["test:poo"],"matchedResource": {"id":"1234567","resourceType": "Patient","versionId": "string","lastUpdated": "string"}} from SNS publish
  • Note - The above event can not be parsed correctly if there's new line character(/n), will need to further verify the parsing behavior once we integrate with the subscription Matcher Lambda

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Bingjiling Bingjiling requested a review from a team as a code owner February 9, 2022 19:43
@github-actions github-actions bot added the size/l label Feb 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #558 (69128d7) into feat-subscriptions (fcf6197) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat-subscriptions     #558   +/-   ##
===================================================
  Coverage               94.84%   94.84%           
===================================================
  Files                       1        1           
  Lines                      97       97           
  Branches                   14       14           
===================================================
  Hits                       92       92           
  Misses                      5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf6197...69128d7. Read the comment docs.

package.json Outdated Show resolved Hide resolved
serverless.yaml Outdated Show resolved Hide resolved
subscriptions/restHook.ts Outdated Show resolved Hide resolved
subscriptions/restHook.ts Outdated Show resolved Hide resolved
@Bingjiling Bingjiling merged commit 2fe34d6 into feat-subscriptions Feb 11, 2022
@Bingjiling Bingjiling deleted the rest-hook branch February 11, 2022 15:19
carvantes added a commit that referenced this pull request Mar 7, 2022
* feat: add GSI to Resource DDB Table (#533)

* feat: Add data validation for subscription (#543)

* fix: remove _subsciptionStatus from export result field (#555)

* feat: sns, sqs, dlq for Subscriptions  (#554)

* feat: Rest hook Lambda (#558)

* feat: subscriptionReaper (#557)

* feat: add subscriptionsMatcher Lambda (#559)

* test: Add Subscriptions test infrastructure/helper (#569)

* fix: update unit tests for subscription reaper (#567)

* test: add subscriptions env vars in gh actions (#572)

* fix: encrypt logs for new Lambda fns (#574)

* test: add Subscription reaper tests (#575)

* feat: emit end to end latency metric from rest-hook Lambda (#570)

* test: add tests for tenant isolation of subscriptions (#577)

* feat: add DLQ for matcher Lambda (#576)

* test: add end to end tests for subscriptions (#578)

* perf: partial failures for restHook Lambda (#579)

* docs: add Subscription docs (#582)

Co-authored-by: Sukeerth Vegaraju <ssvegaraju@yahoo.co.in>
Co-authored-by: zheyanyu <zheyanyu@amazon.com>
Co-authored-by: Yanyu Zheng <yz2690@columbia.edu>
Co-authored-by: brndhpkn <98061326+brndhpkn@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants