Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

feat: sns, sqs, dlq for Subscriptions #554

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Conversation

Bingjiling
Copy link
Contributor

@Bingjiling Bingjiling commented Feb 3, 2022

Issue #, if available:

Description of changes:

  • sns, sqs, dlq for Subscriptions
  • KMS key for encryption
  • Tested message publish through sns, verified message received by sqs

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Bingjiling Bingjiling requested a review from a team as a code owner February 3, 2022 21:24
@github-actions github-actions bot added the size/s label Feb 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #554 (d71100f) into feat-subscriptions (84c9f1a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat-subscriptions     #554   +/-   ##
===================================================
  Coverage               94.84%   94.84%           
===================================================
  Files                       1        1           
  Lines                      97       97           
  Branches                   14       14           
===================================================
  Hits                       92       92           
  Misses                      5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c9f1a...d71100f. Read the comment docs.

Copy link
Contributor

@carvantes carvantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just left a minor comment.

Also, could you move your changes to a new file cloudformation/subscriptions.yaml?
Then we can simply include it onto serverless.yaml. I think that keeps thing better organized.

serverless.yaml Outdated Show resolved Hide resolved
@Bingjiling Bingjiling merged commit fcf6197 into feat-subscriptions Feb 4, 2022
@Bingjiling Bingjiling deleted the shared-infra branch February 4, 2022 19:18
carvantes added a commit that referenced this pull request Mar 7, 2022
* feat: add GSI to Resource DDB Table (#533)

* feat: Add data validation for subscription (#543)

* fix: remove _subsciptionStatus from export result field (#555)

* feat: sns, sqs, dlq for Subscriptions  (#554)

* feat: Rest hook Lambda (#558)

* feat: subscriptionReaper (#557)

* feat: add subscriptionsMatcher Lambda (#559)

* test: Add Subscriptions test infrastructure/helper (#569)

* fix: update unit tests for subscription reaper (#567)

* test: add subscriptions env vars in gh actions (#572)

* fix: encrypt logs for new Lambda fns (#574)

* test: add Subscription reaper tests (#575)

* feat: emit end to end latency metric from rest-hook Lambda (#570)

* test: add tests for tenant isolation of subscriptions (#577)

* feat: add DLQ for matcher Lambda (#576)

* test: add end to end tests for subscriptions (#578)

* perf: partial failures for restHook Lambda (#579)

* docs: add Subscription docs (#582)

Co-authored-by: Sukeerth Vegaraju <ssvegaraju@yahoo.co.in>
Co-authored-by: zheyanyu <zheyanyu@amazon.com>
Co-authored-by: Yanyu Zheng <yz2690@columbia.edu>
Co-authored-by: brndhpkn <98061326+brndhpkn@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants