This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
test: add Subscription reaper tests #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssvegaraju
changed the title
carvantes
suggested changes
Feb 22, 2022
carvantes
approved these changes
Feb 22, 2022
carvantes
changed the title
2 tasks
carvantes
added a commit
that referenced
this pull request
Mar 7, 2022
* feat: add GSI to Resource DDB Table (#533) * feat: Add data validation for subscription (#543) * fix: remove _subsciptionStatus from export result field (#555) * feat: sns, sqs, dlq for Subscriptions (#554) * feat: Rest hook Lambda (#558) * feat: subscriptionReaper (#557) * feat: add subscriptionsMatcher Lambda (#559) * test: Add Subscriptions test infrastructure/helper (#569) * fix: update unit tests for subscription reaper (#567) * test: add subscriptions env vars in gh actions (#572) * fix: encrypt logs for new Lambda fns (#574) * test: add Subscription reaper tests (#575) * feat: emit end to end latency metric from rest-hook Lambda (#570) * test: add tests for tenant isolation of subscriptions (#577) * feat: add DLQ for matcher Lambda (#576) * test: add end to end tests for subscriptions (#578) * perf: partial failures for restHook Lambda (#579) * docs: add Subscription docs (#582) Co-authored-by: Sukeerth Vegaraju <ssvegaraju@yahoo.co.in> Co-authored-by: zheyanyu <zheyanyu@amazon.com> Co-authored-by: Yanyu Zheng <yz2690@columbia.edu> Co-authored-by: brndhpkn <98061326+brndhpkn@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR will be continuously updated with each set of integ tests!
Added tests for the two cases of creating a subscription with an expiration date in the near future and making sure it is deleted by the subscription reaper. Also added a fix for a bug related to the subscription reaper and tenancy.
yarn run int-testand ensuring that the tests passed as expected. I also manually tested the subscription reaper lambda by creating resources with different tenancy permutations and making sure that the current deployment works for both situations.Checklist:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.