Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using crypto api #333

Closed
codingnuclei opened this issue Apr 14, 2024 · 2 comments
Closed

Using crypto api #333

codingnuclei opened this issue Apr 14, 2024 · 2 comments

Comments

@codingnuclei
Copy link

Hi,

I have been evaluating llrt with a preexisting lambda code base (which works as expected on node20) and seeing some sweet performance gains 🔥 🔥

One problem I have stumbled across is with the crypto module.

My lambda running on llrt errors with:

errorType: 'MissingWebCrypto', errorMessage: 'An instance of the Crypto API could not be located',

I have narrowed it down to this lib https://github.com/MasterKale/SimpleWebAuthn - and is throwing an error when this lib tries to access crypto:

https://github.com/MasterKale/SimpleWebAuthn/blob/ba7048cfd791cd9400871d008d21d1354543e2b3/packages/server/src/helpers/iso/isoCrypto/getWebCrypto.ts#L9

There is an issue on their github which helped me get some background on how they are accessing the crypto module
MasterKale/SimpleWebAuthn#517

It looks to me like it should all just work on llrt but i could be very wrong.

Thoughts would be appreciated :)

@richarddavison
Copy link
Contributor

Hi @codingnuclei! Crypto module has currently very limited support. Super cool to see you have nice perf gains! We're working on adding support for the full subtile crypto API! I'm closing this issue as it's being tracked by: #184

@codingnuclei
Copy link
Author

Thanks and keep up the good work!! ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants