Exceptions thrown during module initialization are not caught

[georgesmith46]

Exceptions thrown during the initialization of a global or module are not caught. This means exceptions thrown at this point will be missing the exception message.

How to replicate

Running this

LLRT_NET_DENY=/ ./llrt -e 'console.log("123")'

Outputs

Error: Exception

But it should output

ReferenceError: LLRT_NET_DENY env contains an invalid URI

How to fix

This is where the exceptions should probably be caught:

llrt/llrt_core/src/vm.rs

Line 426 in 9e21153

init_global(&ctx)?;

Example of catching an exception:

llrt/llrt_core/src/vm.rs

Line 448 in 9e21153

if let Err(err) = f(&ctx).catch(&ctx) {

[richarddavison]

That’s right, thanks for finding 👏

[nabetti1720]

Whether or not an error occurs, it would be safer to take the same action below.

llrt/llrt_core/src/vm.rs

Lines 428 to 429 in 9e21153

	timers::init_timers(&ctx)?;
	init(&ctx, module_names)?;

[nabetti1720]

HI @richarddavison and @georgesmith46 , If there is no additional discussion, I would like to submit a PR to resolve this issue, if that is okay?
If you are already working on this issue, please let me know so I can work on another issue.

[georgesmith46]

That's fine with me 👍

Let me know if you need a hand