Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSOSync fails to get binary secrets #130

Closed
dancorne opened this issue May 2, 2023 · 1 comment · May be fixed by #183
Closed

SSOSync fails to get binary secrets #130

dancorne opened this issue May 2, 2023 · 1 comment · May be fixed by #183

Comments

@dancorne
Copy link

dancorne commented May 2, 2023

Describe the bug
If any of the secrets for the Lambda are stored as binary rather than strings, SSOSync stops working with the following error:

{"level":"fatal","msg":"cannot read config: illegal base64 data at input byte 0","time":"2023-05-02T08:04:04Z"} 

To Reproduce
Update one of the secrets to use binary rather than string, eg with the command:

aws secretsmanager update-secret --secret-id SSOSyncGoogleCredentials --secret-binary $(cat credentials.json | base64)

Expected behavior
SSOSync fetches the secret and continues to run.

@ChrisPates
Copy link
Contributor

This request has been merged with related one under a single feature request [Expand the Options for storing the sensitive parameters to include binaray secrets and SSM Parameter Store #180](https://github.com/awslabs/ssosync/issues/180]. Please review and add any specific requirements you feel it doesn't address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants