Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable receiving messages from different message groups in the same Batch for FIFO queues #1041

Closed
tomazfernandes opened this issue Feb 7, 2024 · 3 comments · Fixed by #1192
Labels
component: sqs SQS integration related issue status: ideal-for-contribution We agree it's nice to have but it is not team priority type: enhancement Smaller enhancement in existing integration

Comments

@tomazfernandes
Copy link
Contributor

See #1020

For this we need to add a ContainerOptions to use in the FifoSqsComponentFactory to determine the proper Sink composition.

@tomazfernandes tomazfernandes added component: sqs SQS integration related issue type: enhancement Smaller enhancement in existing integration status: ideal-for-contribution We agree it's nice to have but it is not team priority labels Feb 7, 2024
@alexisgra
Copy link
Contributor

Hello @tomazfernandes ,

From what I've seen and in relation to your messages, I think we should add an option in SqsContainerOptions to not use the MessageGroupingSinkAdapter but another one that doesn't group by message group.

Is that right? If yes, I can do it !
Thanks !

@tomazfernandes
Copy link
Contributor Author

Hey @alexisgra, yup, that sounds about right!

Go for it, I'll be happy to look at the PR.

@alexisgra
Copy link
Contributor

Hi @tomazfernandes,
Thanks for your answer!
I'm currently working on the PR. I was wondering if I should expose a property in the @SqsListener annotation? Or just in the factory?
From what I understand from #1020, the use case may seem rather edgy. Moreover, the property only makes sense for FIFO queues with a BATCH listener.

For now, I've added a boolean messageGrouping field to the SQSContainerOptions, which defaults to true and is used in the FifoSqsComponentFactory to choose the right Sink composition.

Thanks for your help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: sqs SQS integration related issue status: ideal-for-contribution We agree it's nice to have but it is not team priority type: enhancement Smaller enhancement in existing integration
Projects
None yet
2 participants