Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bautajs-fastify-example): add example server in fastify #45

Merged
merged 6 commits into from
Oct 26, 2022

Conversation

Xavier-Redondo
Copy link
Contributor

@Xavier-Redondo Xavier-Redondo commented Oct 17, 2022

PR Checklist

  • I have run npm test locally and all tests are passing.
  • I have added/updated documentation for any new behavior.

PR Description

Closes #33

This is a similar example that we have in bautajs-express-example but using fastify v4 instead of express.

The defined endpoints are the same, and the changes in structure and the code are to reflect the different patterns we use in fastify and the fact that fastify schema validator behaves slightly different than the one from express (it is more strict and ignores anything that is not in the schema).

We add the link to this new package in the Readme.md root folder.

Xavier-Redondo and others added 2 commits October 26, 2022 12:09
Co-authored-by: Fran Herrero <francisco.herrero@axa.com>
Co-authored-by: Fran Herrero <francisco.herrero@axa.com>
@franher franher enabled auto-merge (squash) October 26, 2022 10:27
Copy link
Contributor

@franher franher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franher franher merged commit aad0764 into main Oct 26, 2022
@franher franher deleted the feature/bautajs-fastify-example branch October 26, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add bautajs-example using bautajs-fastify
2 participants