Remove calls to error() from error.h.

[imwints]

On musl systems, liburing cannot build examples and tests due to it's usage of error.h. Replace all calls to error() with fprintf(stderr, ...) and exit(1).

Closes: #786

Signed-off-by: Steffen Winter steffen.winter@proton.me

[axboe]

I'd add a t_error() in the test helpers as a first patch, then a second patch that converts any error() usage to that instead. Will make it much easier to verify that this is a 1-1 substitution and reduces the boiler plate stuff.

[imwints]

I was not quite sure where to put it. Should t_error have the same function definition as error?

[ammarfaizi2]

I was not quite sure where to put it.

test/helpers.c (definition) and test/helpers.h (declaration)

[axboe]

test/helpers.h and test/helpers.c contains code like this to avoid every test needing to re-invent the wheel. And yes, just make it identical to error(), just use va_list and friends for this.

[ammarfaizi2]

I was not quite sure where to put it.

test/helpers.c (definition) and test/helpers.h (declaration)

Oh, wait... you can't use that helper from examples/, so I guess we have
to duplicate it in examples/ too.

[axboe]

Looks good to me know, just a few minor nits that would be nice to address and this can go in.

[ammarfaizi2]

Add the background story to the commit message, please.
Also, link to the GitHub issue. Something like "Fixes" or "Closes"?

[ammarfaizi2]

On musl systems, liburing cannot build examples and tests due to it's usage of error.h. Replace all calls to error() with fprintf(stderr, ...) and exit(1).

Closes: #786

This should go to the commit message.

[imwints]

What about examples/send-zerocopy.c? It has a lot of references to error(), is it okay to just slap an implementation of t_error at the top?

[axboe]

Yeah, just put it in that example file too. With that done and the commit messages update as requested, I think this is good to go.

[ammarfaizi2]

What about examples/send-zerocopy.c? It has a lot of references to error(), is it okay to just slap an implementation of t_error at the top?

Yeah, I think it's the sanest way for now. Integrating test/helpers.c to examples/ doesn't make much sense.

[axboe]

Don't have identical git commit titles. Prefix one with test: and the other with examples: or something like that.

[axboe]

Please fold the last two commits, we should not have a single PR introducing a problem and then a fixup for that afterwards.

[ammarfaizi2]

t_error in examples/send-zerocopy.c needs to be static.

send-zerocopy.c:63:6: error: no previous prototype for function 't_error' [-Werror,-Wmissing-prototypes]
void t_error(int status, int errnum, const char *format, ...)
     ^
send-zerocopy.c:63:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void t_error(int status, int errnum, const char *format, ...)
^
static 
1 error generated.
make[1]: *** [Makefile:36: send-zerocopy] Error 1

[ammarfaizi2]

Looks good.