Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sad-path): tests fail with multiple malicious parties #35

Merged
merged 4 commits into from
Apr 26, 2021
Merged

fix(sad-path): tests fail with multiple malicious parties #35

merged 4 commits into from
Apr 26, 2021

Conversation

ggutoski
Copy link
Contributor

@ggutoski ggutoski commented Apr 23, 2021 •
edited
Loading

Should fix axelarnetwork/tofnd#41 but it does not yet. More investigation needed.

@ggutoski ggutoski requested a review from sdaveas April 23, 2021 06:13
@ggutoski ggutoski marked this pull request as ready for review April 23, 2021 06:48
sdaveas
sdaveas approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@sdaveas sdaveas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean test cases! 😄

@sdaveas sdaveas mentioned this pull request Apr 23, 2021
Closed
@ggutoski
Copy link
Contributor Author

@sdaveas as discussed, please add more test cases and check against tofnd, too. Thank you.

@ggutoski ggutoski merged commit 1ffea79 into master Apr 26, 2021
@ggutoski ggutoski deleted the more-malicious-tests branch April 26, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdaveas sdaveas sdaveas approved these changes

Assignees

@sdaveas sdaveas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thorough testing of behaviours
2 participants
@ggutoski @sdaveas