Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lib/waiver_admin #84

Closed
6 of 7 tasks
axelclark opened this issue Oct 6, 2016 · 1 comment
Closed
6 of 7 tasks

Refactor lib/waiver_admin #84

axelclark opened this issue Oct 6, 2016 · 1 comment
Labels
refactor

Comments

@axelclark
Copy link
Owner

axelclark commented Oct 6, 2016 •
edited
Loading

  • Write tests for all 2nd level functions
  • Move repo transaction to waiver module
  • Pass errors for repo actions within multis to multi
  • get_existing_waiver_data: don't pass nil && get fantasy league id from waiver struct
  • Move three_days_from_now to CalendarAssistant
  • league_teams_count: use FantasyLeague.by_league
  • update_league_waiver_position: move query to FantasyTeam module
@axelclark
Copy link
Owner Author

Deferring moving three_days_from_now

@axelclark axelclark mentioned this issue Oct 7, 2016
Merged
axelclark added a commit that referenced this issue Oct 7, 2016
@axelclark
Refactor WaiverAdmin and Admin modules
dae1a08 
* Wrote tests for WaiverAdmin functions
* Moved roster position update to update_all and one transaction
* Moved Repo transaction to Waiver module
* Used defined queries
* Fixed error when submitting blank form
* Closes #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@axelclark