Issue-25: Update Readme file with lando requirement. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussainweb
reviewed
Oct 5, 2020
| @@ -14,6 +14,7 @@ The script relies on certain developer tools to be available when running. | |||
|
|
|||
| - git - To initialise the project as a repository. | |||
| - composer - To download the dependencies. If composer is not present, the dependencies don't get downloaded. | |||
| - lando - Docker driven local development tool. | |||
There was a problem hiding this comment.
This is not accurate. We don't need lando when running axl-template. In fact, lando is not even required for running the site generated by axl-template. It only generates Lando specific files if you run init-drupal with --lando option or you directly run init-lando.
I would suggest add a new section in existing "Requirements" section to cover these optional dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #25