Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Github #22

Closed
1 of 2 tasks
skippednote opened this issue Feb 8, 2022 · 3 comments
Closed
1 of 2 tasks

Add support for Github #22

skippednote opened this issue Feb 8, 2022 · 3 comments

Comments

@skippednote
Copy link
Contributor

skippednote commented Feb 8, 2022

  • Support Github URLs
  • Support HTTPS URLs besides the currently supported ssh ones
@subhojit-axl
Copy link

Also, IMO there should be a provision to pass the remote host while building the image. Let's say, the user keeps multiple GitHub accounts, and there is a different private key associated with the account. The SSH config in the user's machine might look something like this:

Host github-personal.com
  HostName github.com
  User git
  IdentityFile ~/.ssh/id_rsa_personal

Host github-work.com
  HostName github.com
  User git
  IdentityFile ~/.ssh/id_rsa_work

The db-docker will look for only the selected ones, and it will fail. Therefore, user should have the ability to pass the host name, and therefore controlling which GitHub account is being referred.

@hussainweb
Copy link
Member

@subhojit-axl, this applies not only to Github but generally too. Would you mind creating an issue for it?

@subhojit-axl
Copy link

Issue created #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants