use replace instead of replaceAll to support node<=14

axelpale · Jan 8, 2024 · 6fb5c9c · 6fb5c9c
1 parent 2b543b1
commit 6fb5c9c
Show file tree

Hide file tree

Showing 3 changed files with 66 additions and 3 deletions.
diff --git a/lib/stringify.js b/lib/stringify.js
@@ -31,15 +31,15 @@ const stringify = (value, options) => {
     // - unescaped double or single quotes '
     if (quote === '\'') {
       // escape unescaped single quote
-      const escapedValue = value.replaceAll('\'', '\\\'')
+      const escapedValue = value.replace(/'/g, '\\\'')
       return quote + escapedValue + quote
     } else if (quote === '"') {
       // escape unescaped double quote
-      const escapedValue = value.replaceAll('"', '\\"')
+      const escapedValue = value.replace(/"/g, '\\"')
       return quote + escapedValue + quote
     } else if (quote === '`') {
       // escape unescaped backtick
-      const escapedValue = value.replaceAll('`', '\\`')
+      const escapedValue = value.replace(/`/g, '\\`')
       return quote + escapedValue + quote
     }
     // else

diff --git a/test/cli.test.js b/test/cli.test.js
@@ -512,6 +512,66 @@ describe('genversion cli', () => {
       })
     })
 
+    it('should handle single quotes in properties', (done) => {
+      const clit = new CliTest()
+      const cmd = GENERATE_COMMAND + ' ' +
+        '--source ./test/fixture ' +
+        '--property author ' + P
+      clit.exec(cmd, (err, response) => {
+        if (err) {
+          return done(err)
+        }
+
+        readTemp().should.equal(SIGNATURE +
+          'module.exports = { ' +
+          'name: \'Fo\\\'o "Bar" l`Baz\'' +
+          ' }\n'
+        )
+
+        return done()
+      })
+    })
+
+    it('should handle double quotes in properties', (done) => {
+      const clit = new CliTest()
+      const cmd = GENERATE_COMMAND + ' ' +
+        '--source ./test/fixture ' +
+        '--property author --double ' + P
+      clit.exec(cmd, (err, response) => {
+        if (err) {
+          return done(err)
+        }
+
+        readTemp().should.equal(SIGNATURE +
+          'module.exports = { ' +
+          'name: "Fo\'o \\"Bar\\" l`Baz"' +
+          ' }\n'
+        )
+
+        return done()
+      })
+    })
+
+    it('should handle backticks in properties', (done) => {
+      const clit = new CliTest()
+      const cmd = GENERATE_COMMAND + ' ' +
+        '--source ./test/fixture ' +
+        '--property author -b ' + P
+      clit.exec(cmd, (err, response) => {
+        if (err) {
+          return done(err)
+        }
+
+        readTemp().should.equal(SIGNATURE +
+          'module.exports = { ' +
+          'name: `Fo\'o "Bar" l\\`Baz`' +
+          ' }\n'
+        )
+
+        return done()
+      })
+    })
+
     it('should not understand multiple property flags', (done) => {
       const clit = new CliTest()
       const cmd = GENERATE_COMMAND + ' --property name ' +

diff --git a/test/fixture/package.json b/test/fixture/package.json
@@ -5,6 +5,9 @@
   "keywords": ["foo", "bar"],
   "main": "index.js",
   "license": "MIT",
+  "author": {
+    "name": "Fo'o \"Bar\" l`Baz"
+  },
   "dependencies": {},
   "engines": {
     "node": ">=10.0.0",