Event issues

[ducthotran2010]

    Comments for interfaces and documents

Originally posted by @nxqbao in #22 (review)

Missing event indexed for importance params

[ducthotran2010]

    Declaration of structs should be placed at the top inside the contract. 

Convention note:

Inside each contract, library or interface, use the following order:

1. Type declarations
2. State variables
3. Events
4. Modifiers
5. Functions

Originally posted by @nxqbao in #22 (comment)

ronin-dpos-contracts/contracts/interfaces/IRewardPool.sol

Lines 6 to 43 in 2ef51c7

	/// @dev Emitted when the settled pool is updated.
	event SettledPoolsUpdated(address[] poolAddress, uint256[] accumulatedRps);
	/// @dev Emitted when the pending pool is updated.
	event PendingPoolUpdated(address poolAddress, uint256 accumulatedRps);
	/// @dev Emitted when the fields to calculate settled reward for the user is updated.
	event SettledRewardUpdated(address poolAddress, address user, uint256 debited, uint256 accumulatedRps);
	/// @dev Emitted when the fields to calculate pending reward for the user is updated.
	event PendingRewardUpdated(address poolAddress, address user, uint256 debited, uint256 credited);
	/// @dev Emitted when the user claimed their reward
	event RewardClaimed(address poolAddress, address user, uint256 amount);
	struct PendingRewardFields {
	// Recorded reward amount.
	uint256 debited;
	// The amount rewards that user have already earned.
	uint256 credited;
	// Last period number that the info updated.
	uint256 lastSyncedPeriod;
	}
	struct SettledRewardFields {
	// Recorded reward amount.
	uint256 debited;
	// Accumulated of the amount rewards per share (one unit staking).
	uint256 accumulatedRps;
	}
	struct PendingPool {
	// Accumulated of the amount rewards per share (one unit staking).
	uint256 accumulatedRps;
	}
	struct SettledPool {
	// Last period number that the info updated.
	uint256 lastSyncedPeriod;
	// Accumulated of the amount rewards per share (one unit staking).
	uint256 accumulatedRps;
	}

[ducthotran2010]

    Consider add `indexed` for `address` fields in these events.

Originally posted by @nxqbao in #22 (comment)

[ducthotran2010]

    Event declarations must be placed after enum and struct.

Originally posted by @nxqbao in #22 (comment)

[nxqbao]

All indexed events have been fixed in various feat/fix PRs.