Extract modules #37
Merged
Extract modules #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 20, 2016 12:35
These are really just string.format calls, so no real need to have separate functions and tests.
* Pulls config, api and arcpy helper building into the constructor * Allows configuration to either be a path to a JSON file, or a * pre-constructed dict
Extracts out the argumennt parsing and kickoff into a separate module
These weren't intended to be defined at the class level, but rather instance.
* Removes unneeded class variables * Changes test instance to have a more descriptive name
Passes the correct params object
The command line argument is sufficent for creating a new site
This reverts commit e12e054.
added 6 commits
October 28, 2016 21:34
* Checks existing items in the data store before adding * Exposes client and server paths in config
Importing arcpy takes approximately forever; ideally, we'd like to parse the config file, show usage, etc as quickly as possible. This commit deferrs the import until we have done both of those things, by moving it into the publisher constructor.
|
Fixes #31 |
Since arcpy runs in wine, using \ results in broken server directories
Moves ArcpyHelper import into constructor
Register data
Create site
… extract-modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.