fix: mismatch between values and fields arrays and longToWide on … #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-khaledf
changed the title
mschoch
previously requested changes
May 25, 2023
a-khaledf
force-pushed
the
fix/fix-long-wide-format
branch
from
7be13ff
to
63e4e1e
Compare
|
I proposed one more change, that I think helps with the case Islam most recently pointed out in slack. Are there any remaining concerns with this PR? For me the improvement to filter queries is very significant (basically useless/broken otherwise) |
…series handle totals table groups same as series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…non aggregations