Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix totals switch when submitting via keybinding #31

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

bahlo
Copy link
Member

@bahlo bahlo commented Jun 28, 2023

We need to use a ref for the totals because the function that is called on Cmd/Ctrl+Enter only has access to a reference of the first render because it runs when Monaco is initialized.

We need to use a ref for the totals because the function that is called on
Cmd/Ctrl+Enter only has access to a reference of the first render because it
runs when Monaco is initialized.

Co-authored-by: Igor Bedesqui <igor@axiom.co>
@bahlo bahlo requested a review from kevinehosford June 28, 2023 17:59
Copy link
Contributor

@kevinehosford kevinehosford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bahlo bahlo merged commit cbb1eea into main Jun 28, 2023
@bahlo bahlo deleted the arne/fix-totals-shortcut branch June 28, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants