Ingest stream in chunks #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahlo
force-pushed
the
arne/ingest-stream-in-chunks
branch
from
735f286
to
ce5b66f
Compare
dasfmi
approved these changes
Jul 25, 2022
This will produce smaller requests and makes retries possible.
The type was set up as u8, but it's actually encoded as a string.
The type was set up as u8, but it's actually encoded as a string.
bahlo
force-pushed
the
arne/ingest-stream-in-chunks
branch
from
ce5b66f
to
31d6ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
Client.datasets.ingest_streammethod ingest items in chunks of 1000 items. The advantage of this is to keep within the limits of request size and timeouts. Plus we can retry requests!It also fixes the representation of
QueryMessagePriorityandQueryMessageCode.