Implement clone on the client #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahlo
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Hey @jakejscott, thanks for the PR! There's no reason to not support Clone, will fix CI and get this merged and released under 0.2.1 🚀
If you have any feedback or questions, let me know by either creating issues or joining our Slack community 🙌
|
|
🎉
|
Hi @bahlo I think github actions skipped pushing 0.2.1 to crates.io |
|
Oops, sorry about that, yeah the workflow was not run. That's fixed now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey ya!
I'm working on an example of using axiom with AWS lambda extensions, specifically the logs api. I'm following this example https://github.com/awslabs/aws-lambda-rust-runtime/blob/main/examples/extension-logs-custom-service/src/main.rs#L20
It requires the Service to implement the Clone trait
https://docs.rs/tower/latest/tower/make/struct.Shared.html
Would we be able to make the Axiom client implement Clone?
Thanks for publishing this library :)