Fix serialization issues for CacheStatus on dataset query response #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darach Ennis <darach@gmail.com>
bahlo
approved these changes
Nov 30, 2023
|
ci is probably failing because the pr is coming from a fork. force-merging to verify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a serialization issue with CacheStatus in dataaset apl queries when cache status
is using a composite value that isn't a valid flag in the rust
CacheStatusbitflag struct.The underlying issue was that neither bitflags serialization ( maps to a string, is not wire
compatible with the axiom API which maps to an int ) not custom serialization work when
the cachestatus is a composite of multiple valid flags.
The resolution is to use an alternate marshalling method that is wire compatible and
represents and interprets the flags correctly.