Fix blocking encoding #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahlo
force-pushed
the
arne/fix-blocking-encoding
branch
2 times, most recently
from
ed06b03
to
bf13ad1
Compare
Since the encoding step is not async, it's blocking the async runtime. This moves the encoding to a blocking thread using `spawn_blocking`.
bahlo
force-pushed
the
arne/fix-blocking-encoding
branch
from
bf13ad1
to
de8999d
Compare
dasfmi
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gzip-encoding is a sync operation which blocks the async executor. This PR adds
spawn_blockingto move it to a separate thread.It also runs tests on the async-std runtime.