Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedupe logger #169

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Dedupe logger #169

merged 3 commits into from
Nov 17, 2023

Conversation

c-ehrlich
Copy link
Contributor

  • prevents logger being recreated on rerender by "deep memoizing" it based on config (ie comparing previous and new config by value, not reference)
  • installs Remeda for the equals function - mostly chose this lib because it's known to treeshake well. could also use lodash or write our own deepEquals to avoid the dependency.

@vercel Vercel
Copy link

vercel bot commented Nov 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-axiom-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 4:11pm

@c-ehrlich c-ehrlich merged commit 1b39eac into main Nov 17, 2023
9 checks passed
@c-ehrlich c-ehrlich deleted the dedupe-logger branch November 17, 2023 11:22
@c-ehrlich c-ehrlich mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinehosford kevinehosford kevinehosford approved these changes

@bahlo bahlo Awaiting requested review from bahlo

@dasfmi dasfmi Awaiting requested review from dasfmi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-ehrlich @kevinehosford