Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding responseEncoding to mergeConfig #1745

Merged
merged 3 commits into from
Feb 15, 2020
Merged

Adding responseEncoding to mergeConfig #1745

merged 3 commits into from
Feb 15, 2020

Conversation

ehrhart
Copy link
Contributor

@ehrhart ehrhart commented Aug 20, 2018

responseEncoding has been implemented via #869, but the property hasn't been added in mergeConfig and thus isn't recognized.

This pull request fixes this issue by adding responseEncoding as a valid property in mergeConfig.

Fixes #1561
Related to #869

Copy link
Collaborator

@Alanscut Alanscut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for handling it so long, please resolve the conflict

Copy link
Collaborator

@Alanscut Alanscut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chinesedfan chinesedfan merged commit 17a9671 into axios:master Feb 15, 2020
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

charset latin1 not working
3 participants