Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose XHR instance #200

Merged
merged 1 commit into from Apr 1, 2016

Conversation

@AurelioDeRosa
Copy link
Contributor

commented Jan 22, 2016

Fixes gh-64

@AurelioDeRosa

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2016

Hi @mzabriskie.

I hate to have to ask this, but could you take a look at this PR? We (the team behind Github.js) have switched to axios for our requests and this is the only piece left for the new release. In the previous versions we exposed the XHR istance, so not having it would cause a breaking change.

@AurelioDeRosa

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2016

Any chance to review this PR so that we can address #214?

@clayreimann

This comment has been minimized.

Copy link

commented Feb 21, 2016

@mzabriskie ping.

@mzabriskie

This comment has been minimized.

Copy link
Member

commented Feb 24, 2016

@AurelioDeRosa I'm fine merging this, but will you please do the same for the http adapter?

@AurelioDeRosa

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2016

@mzabriskie is req the object you want to return in the http adapter?

@mzabriskie

This comment has been minimized.

Copy link
Member

commented Mar 6, 2016

@AurelioDeRosa sorry, I just saw your response. Yes, req would be the object to use.

@AurelioDeRosa

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2016

@mzabriskie Applied the change and also rebased.

@nickuraltsev nickuraltsev merged commit a913ea5 into axios:master Apr 1, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.