Updating axios in types to be lower case #2797
Conversation
This is part of #2872 |
Should this be closed then? @chinesedfan |
Totally agree. I'd love to see this merged immediately. I basically made the same MR (#3018) and just would like to know which MR I need to watch now and if there is anything which blocks this MR from being merged as it is three months old |
As the author of #2872 I agree with you that this PR is good and I believe it should be merged, because it's obviously correct. |
Hi, I will be working on merge's again very soon, this should get merged I just think it will go into something like v0.20.1 as we wanted the first 0.20.x release to fix some issues and regressions and not add many new features. Trust me this will be seen to soon. Thanks |
Thank you all for the responses. |
@jasonsaayman I am seeing that v0.20.0 has been released by now. Are you able to share a status update regarding this PR / merges in general, yet? Is there anything we can help with moving this forward? |
All examples use the lower case variable `axios`. However, when auto importing in a TypeScript based editor, the import was named `Axios`, because this is how it was defined in the typings.
b6f5e62
to
b862130
@jasonsaayman @chinesedfan I noticed you have been tagging pull requests for v0.20.1. Can this be included? It’s non breaking. |
This comment has been hidden.
This comment has been hidden.
Yes, first the value is declared, which is an internal detail. Next it’s exported as default, for which the name doesn’t matter. All this affects is how TypeScript editors will autocomplete the default import. Type validity is untouched. |
Ah, indeed. Somehow my brain added an |
0.21.0 appears to be released now. Any update? |
Hi @TimWolla, I will be looking to merge this ASAP. I am just going to get clarity on how we are going to handle breaking changes from here on out. I will have feedback before the end of the week. Thanks |
This one is non-breaking though. |
I can confirm that it is non-breaking. I apologize for any confusion I might have caused with my previous question on that topic. |
Ok cool TS is not my strongest point but just to make 100% certain it works the same as common js in that importing the module imports the default export right? |
TypeScript modules implement the ES 6 module syntax (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import) and then compile it it down to whatever you like, including CommonJS. The default import boils down to |
See this example on the TypeScript playground: https://www.typescriptlang.org/play?module=1#code/JYWwDg9gTgLgBAMwhRUIjgIgIYA9gQDOmA3AFBlIQAUA5ABYwxgBcA9GwKa7bgA2nAHQBjdLQCUJIA Select the proper module in the TS Config if necessary (the select on the right): |
@TimWolla thanks that's great! |
Can confirm that this is not a breaking issue and am happy to implement it |
Co-authored-by: Xianming Zhong <chinesedfan@qq.com>
* Remove the skipping of the `socket` http test * Use different socket path for Win32 - See: https://github.com/nodejs/node-v0.x-archive/blob/master/test/simple/test-pipe-stream.js#L73 - Also: https://github.com/nodejs/node-v0.x-archive/blob/master/test/common.js#L39 * Updating axios in types to be lower case (#2797) Co-authored-by: Xianming Zhong <chinesedfan@qq.com> Co-authored-by: Pilot <timemachine@ctrl-c.club> Co-authored-by: Remco Haszing <remcohaszing@gmail.com> Co-authored-by: Xianming Zhong <chinesedfan@qq.com> Co-authored-by: Jay <jasonsaayman@gmail.com>
All examples use the lower case variable
axios
. However, when auto importingin a TypeScript based editor, the import was named
Axios
, because this is howit was defined in the typings.
Closes #3017