Modified 'isTargetRelativePathBasedOnSource' algorithm to use TypeScr… #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipt 1.5 feature 'rootDir'
p-kudrin
added a commit
that referenced
this pull request
Nov 2, 2015
Modified 'isTargetRelativePathBasedOnSource' algorithm to use TypeScr…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ipt 1.5 feature 'rootDir'
We experienced a broken output. We use "relative paths" and at some circumstances (it seems at random, but reproduce-able) the output directories were mixed up. After a little bit of google-ing I found this bug-report: microsoft/TypeScript#812. The issue was solved by this pull-request: microsoft/TypeScript#2772. It was solved by adding a new parameter "rootDir" which can be used for building output-paths as relative paths based on this root directory under which the files to be compiled are placed. As this matches the typecs-plugin's feature 'Set relative path from target directory to output file based on relative path from source directory to input file' I re-factored this feature to use the new "rootDir" parameter instead of calculating the relative path by the plugin. This fixed our broken output.