Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interoperation): add dummy input mode of cell verify #1044

Merged
merged 10 commits into from
Mar 7, 2023
Merged

feat(interoperation): add dummy input mode of cell verify #1044

merged 10 commits into from
Mar 7, 2023

Conversation

KaoImin
Copy link
Contributor

@KaoImin KaoImin commented Feb 27, 2023 •
edited
Loading

What this PR does / why we need it:

This PR adds dummy input mode of cell verify. The in detailed changes are shown below:

  1. The ICSC inserts an always success deployed cell at the first time of initiation. The deployed transaction hash is keccak("AlwaysSuccessDeployTx") and the output index is 0.
  2. One dummy input is allowed when verify interoperation signature. The dummy cell input has a fixed out point
OutPoint:
    tx_hash: keccak("DummyInputOutpointTxHash")
    index: 0
  1. The always success cell output capacity is changed as if the input is dummy, use dummy_input_cell_len - 1 otherwise use 100.

Which issue(s) this PR fixes:

Fixes #

Which docs this PR relation:

Ref #

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

NIL

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

CI Usage

Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Chaos CI
  • Cargo Clippy
  • Coverage Test
  • E2E Tests
  • Code Format
  • Unit Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

@KaoImin KaoImin requested a review from a team as a code owner February 27, 2023 01:59
@KaoImin
Copy link
Contributor Author

KaoImin commented Feb 27, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Feb 27, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin changed the title feat: add dummy input mode of ckb cell verify [WIP]feat: add dummy input mode of ckb cell verify Feb 28, 2023
@KaoImin KaoImin changed the title [WIP]feat: add dummy input mode of ckb cell verify feat: add dummy input mode of ckb cell verify Mar 2, 2023
@KaoImin KaoImin force-pushed the refactor-interoperation branch 2 times, most recently from 3d8811b to 7a7a8f3 Compare March 6, 2023 10:03
@KaoImin
Copy link
Contributor Author

KaoImin commented Mar 6, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Mar 6, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin changed the title feat: add dummy input mode of ckb cell verify feat(interoperation): add dummy input mode of cell verify Mar 6, 2023
@KaoImin
Copy link
Contributor Author

KaoImin commented Mar 6, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Mar 6, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin
Copy link
Contributor Author

KaoImin commented Mar 7, 2023

/run-ci

@axon-bot
Copy link

axon-bot bot commented Mar 7, 2023

CI tests run on commit:

CI test list:

  • Code Format
  • Cargo Clippy
  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • Unit Tests
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Mar 7, 2023
Merged via the queue into main with commit 1bd3e0b Mar 7, 2023
@KaoImin KaoImin deleted the refactor-interoperation branch March 7, 2023 10:51
@driftluo driftluo mentioned this pull request Mar 13, 2023
Closed
@Flouse Flouse added t:feature and removed feature labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicityin felicityin felicityin approved these changes

@wenyuanhust wenyuanhust Awaiting requested review from wenyuanhust wenyuanhust is a code owner automatically assigned from axonweb3/axon-dev

@peterzhb peterzhb Awaiting requested review from peterzhb peterzhb is a code owner automatically assigned from axonweb3/axon-dev

Assignees
No one assigned
Labels
t:feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaoImin @felicityin @Flouse