-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per branch yum repo #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mctl is not a test. If rpmbuild is broken, that will be reported by acceptance tests
… all if the unit tests don't pass.
…tory being openvdc root
…ne the same thing in two places
…omething goes wrong in the CI
unakatsuo
approved these changes
Dec 22, 2016
… prompted and don't have to do a check to see if the symlink exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set up the rpmbuild script to organize yum repositories based on branch to make it much easier to keep track of them and clean up old ones that are no longer needed.
Check here for an example of how this organizes yum repos: https://ci.openvdc.org/repos/per-branch-yum-repo/
Full list of changes:
yum-builddep
on the spec file instead. It's better to write the build requirements only in the spec file and rely on that being correct.build
stage in the CI torpmbuild
. This makes it more clear what it's doing.rpmbuild
stage after theunit tests
stage. No need to build packages is the unit tests don't even pass.systemctl
is not a test. Even if you runsystemctl status
afterwards like the script was doing, you will not catch a failed startup since it hasn't had enough time to fail yet. Instead we should write a proper acceptance test that calls the CLI and checks if OpenVDC is effectively working. (Which is my next task) An acceptance test like that will also catch broken RPM packages.