Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per branch yum repo #52

Merged
merged 15 commits into from
Jan 4, 2017
Merged

Per branch yum repo #52

merged 15 commits into from
Jan 4, 2017

Conversation

Metallion
Copy link
Contributor

I set up the rpmbuild script to organize yum repositories based on branch to make it much easier to keep track of them and clean up old ones that are no longer needed.

Check here for an example of how this organizes yum repos: https://ci.openvdc.org/repos/per-branch-yum-repo/

Full list of changes:

  • Per branch yum repos
  • Removed build requirements from docker file and run yum-builddep on the spec file instead. It's better to write the build requirements only in the spec file and rely on that being correct.
  • Improved path resolution in the rpmbuild script. It can now be run from any directory and no longer relies on the openvdc root folder being the current working directory.
  • Renamed build stage in the CI to rpmbuild. This makes it more clear what it's doing.
  • Moved rpmbuild stage after the unit tests stage. No need to build packages is the unit tests don't even pass.
  • Removed the rpm install test stage. Installing the RPMs and running systemctl is not a test. Even if you run systemctl status afterwards like the script was doing, you will not catch a failed startup since it hasn't had enough time to fail yet. Instead we should write a proper acceptance test that calls the CLI and checks if OpenVDC is effectively working. (Which is my next task) An acceptance test like that will also catch broken RPM packages.

… prompted and don't have to do a check to see if the symlink exists
@Metallion Metallion merged commit 8fd1112 into master Jan 4, 2017
@unakatsuo unakatsuo deleted the per-branch-yum-repo branch January 6, 2017 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants